Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds unit tests for both the bootstrap and register functionalities while updating configuration and project setup files. Key changes include adding new test cases for sanitizer behavior and upload provider registration, updating TypeScript configuration files, and revising package scripts and settings.
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.test.json | New TS config for test environment |
| server/tsconfig.json | Updated TS config to exclude test files |
| server/tests/utils/* | Added various test utility mocks and schema definitions |
| server/tests/register.test.ts | Added tests covering sanitizer URL conversion logic |
| server/tests/bootstrap.test.ts | Added tests for bootstrap functions including config and permissions |
| server/src/register.ts | Updated register implementation with early exit when no endpoint |
| server/src/controllers/webhook.ts | Refactored webhook service call formatting |
| server/src/bootstrap.ts | Exported extra functions for testing |
| package.json & jest.config.ts | Updated build, lint, test, and coverage configurations |
| common/tsconfig.json & common/pluginId.ts | Updated TS config includes and plugin identifier adjustments |
| admin/src/utils/url.ts | Minor code style improvements |
| .vscode/settings.json | Minor formatting change |
Comments suppressed due to low confidence (1)
server/tests/register.test.ts:39
- [nitpick] There are two tests with the description 'should not convert to imagekit url' in this file, which could be confusing. Consider renaming one of them to more clearly indicate the specific conditions or expectations being tested.
it('should not convert to imagekit url', async () => {
ahnv
force-pushed
the
tests
branch
4 times, most recently
from
3e1cd39 to
c8bf0c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.